Repository navigation
Link explicit Pod PriorityClass and RuntimeClass references - #2007
Open
nadaverell wants to merge 2 commits into
Open
nadaverell wants to merge 2 commits into
nadaverell wants to merge 2 commits into
Conversation
PR Summary by QodoLink explicit Pod PriorityClass and RuntimeClass references
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pod details omit links to the classes that govern priority and runtime selection. Show nonempty
spec.priorityClassNameandspec.runtimeClassNamein the existing Status section, linking to their canonical API groups with cluster scope. Reuse the existing ResourceLink and class renderers.These are explicit Pod declarations. Numeric priority and absent names do not infer a class, and opening RuntimeClass is not proof that its handler is available on a Node. Scope: shared Pod drawer, including SDK consumers on their normal update. Class reverse consumers, workload-template references, resourceContext, graph enrollment and Diagnose expansion are separate follow-ups.
Validation: 16 current and existing Pod renderer tests pass, including actual click handlers and non-inference. Type checking and the full frontend/embed/backend build pass. Actual isolated-kind browser clicks reach both group-qualified cluster-scoped class drawers, with zero page errors; one settled capture was inspected. Existing resource-read authorization and missing/unavailable target states remain in use.
Note
Low Risk
Read-only UI additions in the Pod renderer with navigation via existing ResourceLink; behavior is covered by new tests and does not change auth or data handling.
Overview
Pod details in the shared drawer now surface Priority Class and Runtime Class when
spec.priorityClassNameandspec.runtimeClassNameare set, each as a ResourceLink to the cluster-scopedpriorityclasses(scheduling.k8s.io) andruntimeclasses(node.k8s.io) resources. Numericspec.priorityalone does not show a priority class row.New PodRenderer tests assert click navigation uses the correct kind, API group, and empty namespace, and that class labels are omitted when only a numeric priority is present.
Reviewed by Cursor Bugbot for commit 48046bd. Bugbot is set up for automated code reviews on this repo. Configure here.