Repository navigation
Link scheduler nominated Nodes separately from Pod placement - #2010
Open
nadaverell wants to merge 3 commits into
Open
nadaverell wants to merge 3 commits into
nadaverell wants to merge 3 commits into
Conversation
PR Summary by QodoShow nominated Nodes separately from assigned Pod Nodes
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
Before Kubernetes 1.35 the API server does not clear status.nominatedNodeName when a Pod is bound, so a running Pod can still name a different node. Show the nomination only while the Pod is unbound, give the label the same tooltip affordance as QoS Class, and rewrite the test in the renderer-test style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the scheduler picks a node for a Pending Pod (for example after preempting lower-priority Pods), it records that choice in
status.nominatedNodeNamebefore the Pod is bound. The Pod drawer now shows this as a separate Nominated Node row that links to the Node. A tooltip explains that the nomination can change before binding. The assigned Node row (spec.nodeName) is unchanged.The row only appears while the Pod is unbound. The API server clears a nomination on binding by default only from Kubernetes 1.35; it was opt-in in 1.34 (KEP-5278,
ClearingNominatedNodeNameAfterBinding), so a running Pod can still carry a stale nomination naming a different node. Showing it next to the real Node would be misleading.Scope: the shared Pod drawer only (Radar and Radar Hub via
@skyhook-io/k8s-ui). No graph, MCP context or Diagnose change.Validation: renderer tests cover the link click, a Pod with no nomination, and a bound Pod with a stale, different nomination (which stays hidden). In a browser against a v1.36 kind cluster, the link on a Pending Pod opens the Node drawer. Kubernetes 1.36 rejects a nomination on a bound Pod, so the stale case could not be reproduced live and is covered by the unit test only.
Note
Low Risk
Read-only Pod drawer UI and navigation; display gating avoids misleading stale nomination on bound Pods.
Overview
The Pod detail Status section now surfaces
status.nominatedNodeNameas a separate Nominated Node row (with tooltip) when the Pod has nospec.nodeNameyet, using the same cluster-scoped Node link/navigation as the assigned Node field.Nomination is hidden once the Pod is bound (
spec.nodeNameset), so stale nomination values on older Kubernetes versions are not shown alongside the real node assignment.New
PodNomination.test.tsxcovers link navigation for pending Pods and the bound-Pod hide behavior.Reviewed by Cursor Bugbot for commit e8a830c. Bugbot is set up for automated code reviews on this repo. Configure here.