Repository navigation
ci: gate PRs on a version bump when commands change - #6
Closed
nadaverell wants to merge 1 commit into
Closed
nadaverell wants to merge 1 commit into
nadaverell wants to merge 1 commit into
Conversation
Plugins set an explicit version, so Claude Code only ships updates to installed users when it's bumped — a change can otherwise merge and never reach anyone (as just happened with the /pr edit). Adds a PR gate that requires a plugin.json version bump whenever commands/ changes, and verifies the three version fields (marketplace metadata + plugin entry + plugin.json) stay in sync. No auto-bump: the maintainer still chooses the semver, and non-shipping edits aren't forced.
Contributor
Author
|
Switching to auto-bump-on-merge (main is unprotected, so the bot can bump directly) — superseded by the auto-version-bump workflow. The check approach still made you do the bump manually; auto-bump removes the step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plugins set an explicit
version, so Claude Code only delivers updates to installed users when it's bumped. A command change can otherwise merge tomainand never reach anyone — which just happened: the/predit (#4) shipped no bump and went unreleased until a follow-up.What it does
A
pull_requestcheck that:plugins/skyhook-skills/commands/changed butplugin.jsonversionwasn't bumped vs the base branch, andmarketplace.jsonmetadata.version,marketplace.jsonplugins[].version,plugin.jsonversion).Chosen over auto-bump-on-merge deliberately: the maintainer keeps the semver decision, it needs no write access to
main, and non-shipping edits (README, etc.) aren't forced to bump.Note
Low Risk
CI-only addition with no runtime, auth, or shipped command behavior changes.
Overview
Adds a
pull_request→mainworkflow that blocks merges when shipped plugin commands change without a release bump, and when version metadata drifts across files.On every PR it compares
plugins/skyhook-skills/commands/to the base branch; if anything changed,plugins/skyhook-skills/.claude-plugin/plugin.jsonversionmust differ from base or the job fails with a clear error. It always checks thatplugin.jsonversion,.claude-plugin/marketplace.jsonmetadata.version, andmarketplace.jsonplugins[0].versionmatch.Checkout uses
fetch-depth: 0sogit show/ three-dot diffs againstorigin/${BASE_REF}work. No auto-bump — maintainers choose semver; README-only PRs aren’t forced to bump.Reviewed by Cursor Bugbot for commit 9709667. Bugbot is set up for automated code reviews on this repo. Configure here.