release: v0.7.0#125
Merged
Merged
Conversation
Reviewer's GuideAdds the v0.7.0 release notes to the main changelog using changie and normalizes previous changelog sections to the current formatting style, plus adds the corresponding per-release changie fragment file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new
changes/v0.7.0.mduses*list markers while the mainCHANGELOG.mduses-; consider standardizing on a single bullet style so generated and aggregated changelog entries remain visually consistent. - The text for the cache listener shutdown fix in the v0.6.1 section was slightly changed ("fix context cancellation handling" → "fix cancel context"), so it may be worth double‑checking that this wording change was intentional and still accurately reflects the underlying change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `changes/v0.7.0.md` uses `*` list markers while the main `CHANGELOG.md` uses `-`; consider standardizing on a single bullet style so generated and aggregated changelog entries remain visually consistent.
- The text for the cache listener shutdown fix in the v0.6.1 section was slightly changed ("fix context cancellation handling" → "fix cancel context"), so it may be worth double‑checking that this wording change was intentional and still accurately reflects the underlying change.
## Individual Comments
### Comment 1
<location path="CHANGELOG.md" line_range="27" />
<code_context>
+- Add http.MaxBytesReader (1MB) to HTTP request decoders to prevent memory exhaustion from oversized payloads ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Reorder removeV2Script Lua DEL after cjson.decode for defensive programming ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Replace context.Background() with context.WithCancel for proper lifecycle management and fix shutdown order ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Stop cache listener on rollback and fix cancel context before stopping cache listener in Close ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Enable changelog in GoReleaser config to allow --release-notes flag to populate GitHub release notes ([#120](https://github.com/skyoo2003/acor/issues/120))
</code_context>
<issue_to_address>
**issue (typo):** Phrase "fix cancel context" reads as ungrammatical; consider restoring or clarifying the wording.
The prior wording was "fix context cancellation handling before stopping cache listener in Close," which is clearer and grammatically correct. This change looks like an incomplete edit—please either revert to that version or use a similar full phrase such as "fix context cancellation before stopping the cache listener in Close."
```suggestion
- Replace context.Background() with context.WithCancel for proper lifecycle management and fix context cancellation handling before stopping the cache listener in Close ([#120](https://github.com/skyoo2003/acor/issues/120))
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Add release.mode: replace to explicitly override draft notes with changie - Add changie fragment validation step to fail fast with clear error message
- Use `-` bullet markers in changes/v0.7.0.md to match CHANGELOG.md - Restore v0.6.1 entry wording to original phrasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan