Skip to content

release: v0.7.0#125

Merged
skyoo2003 merged 3 commits into
masterfrom
release/v0.7.0
Apr 19, 2026
Merged

release: v0.7.0#125
skyoo2003 merged 3 commits into
masterfrom
release/v0.7.0

Conversation

@skyoo2003
Copy link
Copy Markdown
Owner

Summary

Test plan

  • Verify CHANGELOG.md renders correctly
  • Merge this PR before publishing the v0.7.0 GitHub release

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 19, 2026

Reviewer's Guide

Adds the v0.7.0 release notes to the main changelog using changie and normalizes previous changelog sections to the current formatting style, plus adds the corresponding per-release changie fragment file.

File-Level Changes

Change Details Files
Add v0.7.0 release section to the main changelog.
  • Insert new v0.7.0 section with Added and Changed subsections and links to the GitHub release and issues
  • Document new RedisBackedAC engine, open-source project setup, and .gitignore reorganization for this release
CHANGELOG.md
Normalize changelog formatting for existing release entries.
  • Add blank lines between headings and lists for better Markdown rendering
  • Convert tight lists to loose lists with consistent leading dashes and spacing
  • Tweak a few descriptions slightly for clarity while preserving content
CHANGELOG.md
Add changie-managed fragment for v0.7.0.
  • Create per-release changelog fragment describing v0.7.0 changes in Added/Changed sections
  • Align fragment content with the corresponding v0.7.0 entry in the main changelog for consistency
changes/v0.7.0.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@skyoo2003 skyoo2003 self-assigned this Apr 19, 2026
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The new changes/v0.7.0.md uses * list markers while the main CHANGELOG.md uses -; consider standardizing on a single bullet style so generated and aggregated changelog entries remain visually consistent.
  • The text for the cache listener shutdown fix in the v0.6.1 section was slightly changed ("fix context cancellation handling" → "fix cancel context"), so it may be worth double‑checking that this wording change was intentional and still accurately reflects the underlying change.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `changes/v0.7.0.md` uses `*` list markers while the main `CHANGELOG.md` uses `-`; consider standardizing on a single bullet style so generated and aggregated changelog entries remain visually consistent.
- The text for the cache listener shutdown fix in the v0.6.1 section was slightly changed ("fix context cancellation handling" → "fix cancel context"), so it may be worth double‑checking that this wording change was intentional and still accurately reflects the underlying change.

## Individual Comments

### Comment 1
<location path="CHANGELOG.md" line_range="27" />
<code_context>
+- Add http.MaxBytesReader (1MB) to HTTP request decoders to prevent memory exhaustion from oversized payloads ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Reorder removeV2Script Lua DEL after cjson.decode for defensive programming ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Replace context.Background() with context.WithCancel for proper lifecycle management and fix shutdown order ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Stop cache listener on rollback and fix cancel context before stopping cache listener in Close ([#120](https://github.com/skyoo2003/acor/issues/120))
+- Enable changelog in GoReleaser config to allow --release-notes flag to populate GitHub release notes ([#120](https://github.com/skyoo2003/acor/issues/120))

</code_context>
<issue_to_address>
**issue (typo):** Phrase "fix cancel context" reads as ungrammatical; consider restoring or clarifying the wording.

The prior wording was "fix context cancellation handling before stopping cache listener in Close," which is clearer and grammatically correct. This change looks like an incomplete edit—please either revert to that version or use a similar full phrase such as "fix context cancellation before stopping the cache listener in Close."

```suggestion
- Replace context.Background() with context.WithCancel for proper lifecycle management and fix context cancellation handling before stopping the cache listener in Close ([#120](https://github.com/skyoo2003/acor/issues/120))
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread CHANGELOG.md
- Add release.mode: replace to explicitly override draft notes with changie
- Add changie fragment validation step to fail fast with clear error message
@github-actions github-actions Bot added the github_actions Pull requests that update Github_actions code label Apr 19, 2026
- Use `-` bullet markers in changes/v0.7.0.md to match CHANGELOG.md
- Restore v0.6.1 entry wording to original phrasing
@skyoo2003 skyoo2003 merged commit d1ee137 into master Apr 19, 2026
6 checks passed
@skyoo2003 skyoo2003 deleted the release/v0.7.0 branch April 19, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant