Skip to content

fix: Potential fix for code scanning alert no. 14: Uncontrolled data used in path expression #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyoo2003 merged 3 commits into from
Apr 20, 2026
Merged

fix: Potential fix for code scanning alert no. 14: Uncontrolled data used in path expression #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f19c11
Potential fix for code scanning alert no. 14: Uncontrolled data used …
skyoo2003 Apr 19, 2026
bf72ff6
fix: resolve merge conflict in safePath combining segment validation …
skyoo2003 Apr 20, 2026
c4812cd
fix: address review comments on safePath - skip empty segments and re…
skyoo2003 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions internal/services/s3/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,36 @@ func validPathComponent(part string) error {
// escape the base directory. It returns an error on path traversal attempts.
// All components must be single path segments (no separators).
func (fs *FileStore) safePath(parts ...string) (string, error) {
joined := filepath.Join(append([]string{fs.baseDir}, parts...)...)
cleaned := filepath.Clean(joined)

// Resolve symlinks if the candidate path exists; otherwise use cleaned.
candidate := cleaned
if resolved, err := filepath.EvalSymlinks(cleaned); err == nil {
cleanParts := make([]string, 0, len(parts))
for _, part := range parts {
if part == "" {
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
continue
}
if filepath.IsAbs(part) {
return "", fmt.Errorf("absolute path segment not allowed: %s", part)
}
cleanPart := filepath.Clean(part)
if cleanPart == ".." || strings.HasPrefix(cleanPart, ".."+string(filepath.Separator)) {
return "", fmt.Errorf("path traversal detected in segment: %s", part)
}
cleanParts = append(cleanParts, cleanPart)
}

candidate := filepath.Join(append([]string{fs.baseDir}, cleanParts...)...)

// Resolve symlinks if the candidate path exists; otherwise use the joined path.
if resolved, err := filepath.EvalSymlinks(candidate); err == nil {
candidate = resolved
}

rel, err := filepath.Rel(fs.baseDir, candidate)
if err != nil {
return "", fmt.Errorf("resolve relative path: %w", err)
}
if rel == ".." || strings.HasPrefix(rel, ".."+string(filepath.Separator)) {
if rel == ".." || strings.HasPrefix(rel, ".."+string(filepath.Separator)) || filepath.IsAbs(rel) {
return "", fmt.Errorf("path traversal detected: %s", candidate)
}

return candidate, nil
}

Expand Down
Loading