Skip to content

fix: Potential fix for code scanning alert no. 12: Uncontrolled data used in path expression #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyoo2003 merged 3 commits into from
Apr 20, 2026
Merged

fix: Potential fix for code scanning alert no. 12: Uncontrolled data used in path expression #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af3ae49
Potential fix for code scanning alert no. 12: Uncontrolled data used …
skyoo2003 Apr 19, 2026
0533be0
Merge branch 'main' into alert-autofix-12
skyoo2003 Apr 20, 2026
85e710e
fix: centralize upload ID validation across all multipart handlers
skyoo2003 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/services/s3/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,9 @@ func (p *S3Provider) uploadPart(_ context.Context, bucket, key, uploadID, partNu
if err != nil || partNumber < 1 {
return xmlError("InvalidArgument", "invalid part number", http.StatusBadRequest), nil
}
if !shared.ValidateUploadID(uploadID) {
return xmlError("InvalidArgument", "invalid uploadId", http.StatusBadRequest), nil
}

if _, err := p.metaStore.GetMultipartUpload(uploadID); err != nil {
if errors.Is(err, ErrUploadNotFound) {
Expand Down Expand Up @@ -1005,6 +1008,9 @@ func (p *S3Provider) listMultipartUploads(_ context.Context, bucket string) (*pl
}

func (p *S3Provider) listParts(_ context.Context, bucket, key, uploadID string) (*plugin.Response, error) {
if !shared.ValidateUploadID(uploadID) {
return xmlError("InvalidArgument", "invalid uploadId", http.StatusBadRequest), nil
}
if _, err := p.metaStore.GetMultipartUpload(uploadID); err != nil {
if errors.Is(err, ErrUploadNotFound) {
return xmlError("NoSuchUpload", "upload not found", http.StatusNotFound), nil
Expand Down
Loading