fix: Potential fix for code scanning alert no. 5: Uncontrolled data used in path expression

[skyoo2003]

Potential fix for https://github.com/skyoo2003/devcloud/security/code-scanning/5

To fix this without changing intended behavior, validate path components (accountID, functionName) as single safe path segments before constructing filesystem paths.

Best approach in this code:

• In internal/services/lambda/store.go, add a small validator method (for example validatePathComponent) that rejects:
  • empty values,
  • "." / "..",
  • any / or \ separators.
• Call this validator in codePath for both accountID and functionName before filepath.Join.
• Keep the existing base-directory containment check as defense-in-depth.
• Also handle filepath.Abs errors instead of ignoring them.

This addresses all alert variants because they all converge on the same sink (os.WriteFile(path, ...)) and same tainted source path.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[sourcery-ai]

Reviewer's Guide

Adds strict validation of path components used in Lambda code storage paths and propagates filesystem path resolution errors to fully address a code-scanning alert about uncontrolled data in path expressions.

File-Level Changes

Change	Details	Files
Introduce reusable validator for individual path components and use it in Lambda code path construction.	Add validatePathComponent helper that rejects empty values, dot/dot-dot, and any path separators in a path component. Invoke validatePathComponent for accountID and functionName at the start of codePath to ensure both are single safe path segments.	internal/services/lambda/store.go
Strengthen path containment logic by handling errors from filepath.Abs instead of ignoring them.	Capture and return errors from filepath.Abs when resolving the base code directory. Capture and return errors from filepath.Abs when resolving the cleaned code path before performing the prefix check.	internal/services/lambda/store.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}