Update release process#206
Merged
Merged
Conversation
- Upgrade GoReleaser to v2 config format (dockers → dockers_v2) - Enable changelog generation (was skipped) - Add non-root user to Dockerfile.goreleaser with multi-platform support - Add release-drafter workflow and config for automated release notes - Extend Makefile with vet, coverage, race, lint-fix targets
Contributor
Reviewer's GuideUpdates the release tooling by migrating GoReleaser to v2, tightening the build/test Make targets, modernizing Docker image publishing, and introducing automated release notes via Release Drafter while enabling GoReleaser-driven changelog generation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".goreleaser.yml" line_range="79-88" />
<code_context>
-dockers:
-- ids:
- - kvs
+dockers_v2:
+- images:
+ - ghcr.io/skyoo2003/kvs
dockerfile: Dockerfile.goreleaser
- use_buildx: true
- image_templates:
- - "ghcr.io/skyoo2003/kvs:{{ .Tag }}-alpine"
- - "ghcr.io/skyoo2003/kvs:v{{ .Major }}.{{ .Minor }}-alpine"
- - "ghcr.io/skyoo2003/kvs:v{{ .Major }}-alpine"
- - "ghcr.io/skyoo2003/kvs:latest-alpine"
- build_flag_templates:
- - "--label=org.opencontainers.image.created={{ .Date }}"
- - "--label=org.opencontainers.image.title={{ .ProjectName }}"
- - "--label=org.opencontainers.image.revision={{ .FullCommit }}"
- - "--label=org.opencontainers.image.version={{ .Version }}"
- skip_push: false
+ ids:
+ - kvs
+ sbom: false
+ flags:
+ - "--provenance=false"
+ tags:
+ - "{{ .Tag }}-alpine"
+ - "v{{ .Major }}.{{ .Minor }}-alpine"
+ - "v{{ .Major }}-alpine"
+ - "latest-alpine"
+ labels:
+ org.opencontainers.image.created: "{{ .Date }}"
+ org.opencontainers.image.source: "https://github.com/skyoo2003/kvs"
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `dockers_v2` instead of `dockers` is likely not a valid key in GoReleaser v2 and may prevent Docker images from being built/pushed.
In v2, the top‑level key remains `dockers`; only the nested fields change. Please keep `dockers` and update the inner fields (`images`, `tags`, `sbom`, `labels`, etc.) to the v2 schema. Using `dockers_v2` will likely cause GoReleaser to ignore this block.
</issue_to_address>
### Comment 2
<location path=".github/release-drafter.yml" line_range="31-15" />
<code_context>
+ - "github_actions"
+
+version-resolver:
+ minor:
+ labels:
+ - "breaking_changes"
+ - "feature_request"
+ - "enhancement"
+ patch:
+ labels:
</code_context>
<issue_to_address>
**issue (bug_risk):** Tagging `breaking_changes` as a `minor` bump will under-version breaking releases; it likely belongs under `major`.
Because this label currently lives under the `minor` section, any PR marked `breaking_changes` will only trigger a minor bump, which can violate semantic versioning and surprise consumers. Please move `breaking_changes` to a `major:` block so those releases correctly bump the major version.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Revert dockers_v2 back to dockers (top-level key unchanged in GoReleaser v2) - Move breaking_changes to major version-resolver for correct semver
Pre-1.0 project uses minor bumps for breaking changes intentionally.
The duplicate govet key merge accidentally activated fieldalignment, which fails on pre-existing struct layouts outside this PR's scope.
Owner
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dockers→dockers_v2)Dockerfile.goreleaserwith multi-platform build supportvet,coverage,race,lint-fixtargetsTest plan
make allruns successfully (vet → lint → test → build)make coveragegenerates coverage reportmake racepasses