Fix GoReleaser v2 config schema#209
Merged
Merged
Conversation
- brews.tap → brews.repository (removed in v2) - brews.folder → brews.directory (removed in v2) - dockers → dockers_v2 (new v2 Docker config section)
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the GoReleaser configuration to match v2 schema changes for Homebrew taps and Docker definitions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".goreleaser.yml" line_range="79-82" />
<code_context>
skip_upload: false
-dockers:
+dockers_v2:
- images:
- ghcr.io/skyoo2003/kvs
dockerfile: Dockerfile.goreleaser
</code_context>
<issue_to_address>
**issue (bug_risk):** The `dockers_v2` key is likely invalid and will be ignored by GoReleaser.
GoReleaser only recognizes `dockers` (and `docker_manifests`) as top-level keys; `dockers_v2` is not part of the schema, so this block will be ignored. Rename it to `dockers` and, if you intend to use the v2 Docker builder, update the nested fields accordingly so your images are actually built and published.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+79
to
82
| dockers_v2: | ||
| - images: | ||
| - ghcr.io/skyoo2003/kvs | ||
| dockerfile: Dockerfile.goreleaser |
Contributor
There was a problem hiding this comment.
issue (bug_risk): The dockers_v2 key is likely invalid and will be ignored by GoReleaser.
GoReleaser only recognizes dockers (and docker_manifests) as top-level keys; dockers_v2 is not part of the schema, so this block will be ignored. Rename it to dockers and, if you intend to use the v2 Docker builder, update the nested fields accordingly so your images are actually built and published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brews.tap→brews.repository(removed in GoReleaser v2)brews.folder→brews.directory(removed in GoReleaser v2)dockers→dockers_v2(new v2 Docker config section)