This repository was archived by the owner on Jun 23, 2025. It is now read-only.
Chore/delivering to gov infra (2024.12.09) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonorri
changed the title
Member
|
I wonder whether we should deliver this via 3 PRs. One for each |
gzur
approved these changes
Dec 9, 2024
Member
gzur
left a comment
gzur
left a comment
There was a problem hiding this comment.
🚢🇮🇹
Though, there is a depth charge in the defaults module that we need to address somehow.
It can go through, because it DOES reflect the current state of affairs for that environmen, but it fills me with shame and sadness.
| suffix = (var.org_code == "fjr" && var.tier == "dev") ? local.fjr_dev_suffix : local.default_suffix | ||
| tags = merge(var.tags, local.default_tags, local.iac_tags) | ||
| suffix = (var.org_code == "fjr" && var.tier == "dev") ? local.fjr_dev_suffix : local.default_suffix | ||
| resource_name_template = var.org_code == "fjr" ? local.fjr_resource_name_template : local.default_resource_name_template |
Member
There was a problem hiding this comment.
This is depth charge waiting for somebody (fjárlagakerfi) to sail into it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up file headers
Tags from examples now flow through better in databricks module.
Removing subscription creation from datalakehouse module.
Removing mgmt group association from datalakehouse module.
Disabling a noisy alert in the warehouse.
A front door added in front of the networked app service.
Networked app service module has been expanded to allow for more configuration options.
Refactoring network-base module.