Skip to content

A missing crop is a rejection, not an unavailable model (found by strict mode on the pod) - #24

Merged
sladojevicm merged 1 commit into
developfrom
fix/no-crop-is-a-rejection
Sep 17, 2026
Merged

sladojevicm merged 1 commit into
developfrom
fix/no-crop-is-a-rejection

Conversation

@sladojevicm

Copy link
Copy Markdown
Owner

LocalGpuEngine.regenerate classified every exception from _run_gen as unavailable, including no crop staged for this object (crop staging found no usable view). With SOBA_STRICT=1 that failed the whole pod run on track 94 of office_3 before assembly. A missing crop is a verdict on the object: now rejected: no crop staged, recorded as engine_declined with its reason, cacheable, and it does not trip strict mode. Test added.

🤖 Generated with Claude Code

…A_STRICT=1 on the pod)

LocalGpuEngine.regenerate classified every exception from _run_gen as
"unavailable", including "no crop staged for this object" (crop staging found
no usable view: mask under min_area_px). Under SOBA_STRICT=1 that failed the
whole run on track 94 of office_3 before assembly. It is a verdict on the
object: recorded as engine_declined with its reason, cacheable, not strict.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sladojevicm
sladojevicm merged commit 7819260 into develop Sep 17, 2026
8 checks passed
sladojevicm added a commit that referenced this pull request Sep 17, 2026
…les regenerated (measured numbers)

Run 6b (strict): 4/4 PatchComplete meshes fused from the engine, pymeshfix
seals, 10/10 CoACD colliders, 7 TripoSG objects, no fallback, 880 s. Strict
first failed on a misclassified missing crop (fixed in PR #24). The 8 _v2
bundles were regenerated on the pod: match-test 0.0 mm, 12 min for all rooms,
2.5 GB; sync_bundles.md now carries measured sizes/times and --no-same-owner.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T4fWTqvtzrSuC3ZmHemmA6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant