ci: lint the shell scripts in hack/ - #78
Merged
Merged
Conversation
hack/check-coverage.sh and hack/check-rbac.sh decide whether CI passes, and nothing was linting them. A quoting mistake there either fails builds or, worse, makes a gate silently succeed. Both scripts are already clean, so this adds no findings; it stops the next edit from introducing one. Wired into the CI workflow and into make ci so local and CI ask the same question. Signed-off-by: Simon Lauger <simon@lauger.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hack/check-coverage.shandhack/check-rbac.shdecide whether CI passes, and nothing was linting them. A quoting mistake in a gate either fails builds for the wrong reason or, worse, makes the gate silently succeed while appearing to run.Both scripts are already clean, so this adds no findings today. The point is the next edit.
Wired into the CI workflow and into
make ci, so local and CI ask the same question, andmake shellcheckfails with an install hint rather than doing nothing when the tool is missing.Scans
hack/rather thanimages/, since that is where this project's scripts live.Test plan
shellcheck hack/*.shis clean, andmake cipasses end to end.echo $BROKENto one script makes it report SC2086, and removing it restores a clean run.actionlintreports no findings on the new workflow or the changedci.yaml.