fix: keep --remote running when public IPv4 lookup fails - #2725
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: keep --remote running when public IPv4 lookup fails#2725BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
publicIpv4() throws (for example DOMException when DNS is blocked), which crashed the CLI on --remote=password and the QR shortcut.
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
public-ip publicIpv4() throws when the public address cannot be determined (blocked DNS, DOMException in practice). Both --remote startup and the QR shortcut awaited it unguarded, so slidev --remote= crashed instead of staying on LAN URLs.
Catch the lookup and treat failure as no public IP. printInfo already omits that line when the value is missing, so remote/QR keep working.
Fixes #2724