fix(cli): don't crash when the public IP can't be resolved - #2726
Open
lazerg wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a network where the public IP can't be resolved (blocked DNS, for example),
slidev --remote=<password>dies before printing anything.publicIpv4()rejects there, and neither call site guards it: the dev server one takes down the process withDOMException [TimeoutError], and thec(qrcode) shortcut leaves an unhandled rejection.The public IP only adds one extra "remote control" URL, so both calls now go through a small helper that catches the failure and warns, the same way the failed-to-open-browser path does.
printInfoalready treats the IP as optional and still prints the LAN URLs.There's no test harness for
cli.tshere, so I checked it by hand against the starter demo withpublic-ipstubbed to reject with the sameTimeoutError. Onmainit crashes at startup; on this branch it warns, serves the deck, and still renders the QR code. With the stub removed the public IP shows up as before.Fixes #2724