Fix terminal width detection on Linux#8
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change expands the TTY validation filter in ChangesTerminal Column Detection TTY Validation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
get_terminal_cols()walks the process tree looking for a parent with a TTY, but on Linux the no-TTY marker is?, not??like macOS. The walk stopped at the first process, tried to open/dev/?, failed silently, and fell back to 80 columns. This madefit_parts()drop most statusline components on every Linux system.Changes
claude_tui_components/utils.py, added"?"to the TTY exclusion check so the parent-walk skips no-TTY processes on LinuxFixes #7
Summary by CodeRabbit