Conversation
The time picker inputs, in the widgets and in the material library, the usecases demo's line edit, and the visual editor's inspector field left their TextInput the accessible role it gets by default, while the element around it carries a text input role too. Both then describe the same text, which accesskit_consumer refuses: it aborts over a child that two items claim, so a screen reader attaching to one of these closed the program. The inner input now stays out of the description, the way lineedit-base and the other widget bases already do it, and the element around it describes the field with its own label and value.
An element with a text input role describes the text of the TextInput below it, and an accessible text input in between describes the same text again. accesskit_consumer aborts the process over a child that two items claim, so a UI built that way closes as soon as a screen reader attaches. Four places in this repository were built that way, none of them noticed until a user ran into it. The check walks the tree the way the runtime does: a role set where a component is used counts together with the elements inside that component, an element and the root of the component it instantiates are one item, and a popup starts a tree of its own. The role an element ends up with is the one its most derived binding names, since setting the role where a component is used writes it to the root element of that component, which is what makes 'accessible-role: none' the fix to point at in every case.
tronical
force-pushed
the
simon/textinput-nest-diagnostic
branch
from
September 11, 2026 20:08
688f85b to
51a981d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An element with a text input role describes the text of the TextInput below
it, and an accessible text input in between describes the same text again.
accesskit_consumer aborts the process over a child that two items claim, so a
UI built that way closes as soon as a screen reader attaches. Three places in
this repository were built that way, none of them noticed until a user ran
into it.
The check walks the tree the way the runtime does: a role set where a
component is used counts together with the elements inside that component, an
element and the root of the component it instantiates are one item, and a
popup starts a tree of its own. The role an element ends up with is the one
its most derived binding names, since setting the role where a component is
used writes it to the root element of that component, which is what makes
'accessible-role: none' the fix to point at in every case.