Conversation
Contributor
|
👋 Welcome, and thanks for your pull request! If you haven't yet, take a look at CONTRIBUTING.md. Before we can merge it, tick the box at the end of the description to confirm that you agree to the licensing described in CONTRIBUTING.md#license. You only do this once. If you can't agree, tell us in a comment instead. We're a small team and reviews can take a while. If you don't hear back, nudge us in our public chat. |
Author
|
I did not think a PR description was necessary because the change is minimal and is nicely described in the comment. |
The tests workspace builds i-slint-renderer-skia as a dependency, not a workspace member, so nothing enables a softbuffer windowing backend — and softbuffer 0.4 fails to compile backend-less (empty dispatch enum, E0392), breaking `cargo test -p test-driver-screenshots`. Enable `x11` + `wayland` unconditionally: the display server is picked at runtime, `dlopen` needs nothing system-level to build, and the flags are no-ops off Linux. Revert once a softbuffer release compiles without a backend.
Sporknife
force-pushed
the
mstarc/appolonius-the-duster
branch
from
September 13, 2026 20:00
91d713e to
96528c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.