Conversation
0x6e
reviewed
Sep 14, 2026
| The height of the visible area of the text edit (not including the scrollbar) | ||
| </SlintProperty> | ||
|
|
||
| ## Functions |
Collaborator
Contributor
Author
There was a problem hiding this comment.
I don't understand how my change broke it
Collaborator
There was a problem hiding this comment.
You didn't :) I was asking if you could fix it as a follow up/separate PR though, or I will do it.
Contributor
Author
There was a problem hiding this comment.
Ah ok :) I will fix it this afternoon :)
Add forwarding functions to the existing TextInput behaviour, and add context menu entries if lineedit is not enable/read-only.
Montel
force-pushed
the
add_undo_redo_textedit
branch
from
September 15, 2026 08:20
0816f86 to
e0aac55
Compare
0x6e
reviewed
Sep 15, 2026
0x6e
requested changes
Sep 15, 2026
0x6e
left a comment
0x6e
left a comment
Collaborator
There was a problem hiding this comment.
Not sure how to un-approve a change.
0x6e
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cupertino style didn't have enable/readonly support
I sync with other style