Visual Editor: Re-enable and simplify canvas interaction tests - #13467
Merged
Merged
Conversation
Enable movement and corner-radius cases and check dragging outside the window through pointer release. Remove redundant fixture rewrites, parameter construction, and the unused cancellation helper. The headless UI suite passes with 411 passed and 16 skipped.
Descendant queries omit fully clipped items. Keep the live selection frame and radius tooltip references during the interaction so off-screen drags still verify transient changes before release. Remove the unused single-transient-state option; boundary drags now retain the multiple-state assertion.
Remove unchanged fixture rewrites and unused baseline reads. Share boundary target calculations and geometry formatting, simplify radius parameters, and read only the final frame rotation. Retain all 134 canvas cases and the live-state, exact-source, and installed-preview assertions. Canvas and undo/redo validation passed with 143 tests and 3 existing skips. The full headless suite had 420 passed, 16 skipped, and the existing unrelated outline-preview failure.
CI read the previous stop color immediately after switching gradient stops. Wait for the color field to show the selected stop before asserting its exact value in both directions.
tronical
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Many tests were being skipped while the features didn't exist. They now do and this hooks them up.