feat(io): expose FileIO configuration properties - #14
Open
smaheshwar-pltr wants to merge 2 commits into
Open
smaheshwar-pltr wants to merge 2 commits into
smaheshwar-pltr wants to merge 2 commits into
Conversation
smaheshwar-pltr
commented
Jun 27, 2026
smaheshwar-pltr
force-pushed
the
rest-fileio-properties
branch
from
June 27, 2026 23:21
fc46f62 to
13a013b
Compare
smaheshwar-pltr
commented
Jun 27, 2026
smaheshwar-pltr
force-pushed
the
rest-fileio-properties
branch
2 times, most recently
from
June 28, 2026 00:05
fe44eb3 to
20f9c65
Compare
smaheshwar-pltr
force-pushed
the
rest-fileio-properties
branch
from
September 6, 2026 22:05
55f8fc8 to
32ebd8e
Compare
smaheshwar-pltr
commented
Sep 7, 2026
| return storage_credentials_; | ||
| } | ||
|
|
||
| const std::unordered_map<std::string, std::string>& properties() const override { |
Owner
Author
There was a problem hiding this comment.
Exposing the FileIO's configuration as a flat map is how other implementations surface it to engines:
- Java
FileIO.properties(): https://github.com/apache/iceberg/blob/874e4096e5d16fddbbf43b91f20e248616232cc3/api/src/main/java/org/apache/iceberg/io/FileIO.java#L105 - Rust
config().props()(&HashMap): https://github.com/apache/iceberg-rust/blob/47eaef7185916eb86add59d913eb872a06810465/crates/iceberg/src/io/storage/config/mod.rs#L78 - PyIceberg
table.io.properties: https://github.com/apache/iceberg-python/blob/01a86f987d1924ca3246a2b985b78890ec0c0fbd/pyiceberg/io/__init__.py#L260-L263 - Trino reads
baseTable.io().properties()directly: https://github.com/trinodb/trino/blob/c9a2b907234b94c230cc26e2993411d4afdd77c5/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/IcebergRestCatalogFileSystemFactory.java#L60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
FileIO::properties()and expose configuration from bothArrowS3FileIOandResolvingFileIO. Other implementations retain an empty default.Why
Engines that perform their own I/O need the resolved table FileIO configuration, including credentials returned in REST table config. This follows Java
FileIO.properties()and PyIceberg's property-map API. Structuredstorage-credentialsremain onSupportsStorageCredentials.The resolver override is required after the scheme-based FileIO work in apache#828 and apache#889. Because the map may contain credentials, the API contract warns callers not to log or expose it.
Validation
Added S3 and REST resolver coverage, including catalog/table merge precedence. The full GitHub Actions matrix passed.
AI assistance: Codex was used to rebase and adapt the existing change to the current resolver architecture. I reviewed the resulting diff and validation.