Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iceberg/expression/json_serde_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace iceberg {

/// \brief Converts an operation type string to an Expression::Operation.
///
/// \param typeStr The operation type string
/// \param json The JSON value containing the operation type string
/// \return The corresponding Operation or an error if unknown
ICEBERG_EXPORT Result<Expression::Operation> OperationTypeFromJson(
const nlohmann::json& json);
Expand Down
6 changes: 3 additions & 3 deletions src/iceberg/file_io.h
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,13 @@ class ICEBERG_EXPORT FileIO {
///
/// \param file_location The location of the file to write.
/// \param content The content to write to the file.
/// \return void if the write succeeded, an error code if the write failed.
/// \return Status indicating success, or an error if the write failed.
virtual Status WriteFile(const std::string& file_location, std::string_view content);

/// \brief Delete a file at the given location.
///
/// \param file_location The location of the file to delete.
/// \return void if the delete succeeded, an error code if the delete failed.
/// \return Status indicating success, or an error if the delete failed.
virtual Status DeleteFile(const std::string& file_location) {
return NotImplemented("DeleteFile not implemented");
}
Expand All @@ -175,7 +175,7 @@ class ICEBERG_EXPORT FileIO {
/// and returns the first error encountered.
///
/// \param file_locations The locations of the files to delete.
/// \return void if all deletes succeed, or an error code if any delete fails.
/// \return Status indicating success, or an error if any delete fails.
virtual Status DeleteFiles(const std::vector<std::string>& file_locations);

/// \brief Return storage-credential support when implemented by this FileIO.
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/partition_spec.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class ICEBERG_EXPORT PartitionSpec : public util::Formattable {
/// \param schema The schema to bind the partition spec to.
/// \param spec_id The spec ID.
/// \param fields The partition fields.
/// \param allowMissingFields Whether to skip validation for partition fields whose
/// \param allow_missing_fields Whether to skip validation for partition fields whose
/// source columns have been dropped from the schema.
/// \param last_assigned_field_id The last assigned field ID assigned to ensure new
/// fields get unique IDs.
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/schema.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class ICEBERG_EXPORT Schema : public StructType {
/// \brief Returns the canonical field name for the given id.
///
/// \param field_id The id of the field to get the canonical name for.
/// \return The canocinal column name of the field with the given id, or std::nullopt if
/// \return The canonical column name of the field with the given id, or std::nullopt if
/// not found.
Result<std::optional<std::string_view>> FindColumnNameById(int32_t field_id) const;

Expand Down
Loading