Skip to content

AMQP: Stop connection retry loop on shutdown to avoid RejectedExecutionException - #3491

Merged
cescoffier merged 1 commit into
smallrye:mainfrom
ozangunalp:amqp-fix-rejected-exception
Sep 4, 2026
Merged

AMQP: Stop connection retry loop on shutdown to avoid RejectedExecutionException#3491
cescoffier merged 1 commit into
smallrye:mainfrom
ozangunalp:amqp-fix-rejected-exception

Conversation

@ozangunalp

Copy link
Copy Markdown
Collaborator

Close ConnectionHolder before closing the AMQP client during shutdown, preventing the memoized connection Uni from retrying on a terminated Vert.x event loop.

…onException

Close ConnectionHolder before closing the AMQP client during shutdown,
preventing the memoized connection Uni from retrying on a terminated
Vert.x event loop.
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.87%. Comparing base (a96442f) to head (0134e7e).
⚠️ Report is 1225 commits behind head on main.

Files with missing lines Patch % Lines
...lrye/reactive/messaging/amqp/ConnectionHolder.java 86.66% 3 Missing and 3 partials ⚠️
...lrye/reactive/messaging/amqp/AmqpClientHolder.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3491      +/-   ##
============================================
+ Coverage     77.47%   77.87%   +0.40%     
- Complexity     3778     5624    +1846     
============================================
  Files           306      485     +179     
  Lines         12673    18787    +6114     
  Branches       1648     2313     +665     
============================================
+ Hits           9818    14631    +4813     
- Misses         2116     3014     +898     
- Partials        739     1142     +403     
Files with missing lines Coverage Δ
...mallrye/reactive/messaging/amqp/AmqpConnector.java 82.50% <100.00%> (+1.87%) ⬆️
...lrye/reactive/messaging/amqp/AmqpClientHolder.java 92.30% <66.66%> (ø)
...lrye/reactive/messaging/amqp/ConnectionHolder.java 87.09% <86.66%> (+19.52%) ⬆️

... and 284 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cescoffier
cescoffier merged commit c264ab0 into smallrye:main Sep 4, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants