docs(spec): amend Spec 049 — legalize server_quarantined status (six-value taxonomy)#779
Merged
Conversation
…value taxonomy) Aligns Spec 049 with PR #778, which adds a sixth disabled-tool status, server_quarantined, surfaced by a dedicated quarantined-tool discovery pass (quarantined tools are deliberately excluded from the search index as a TPA defense). Spec 049 pinned the taxonomy to exactly five values and assumed all locked tools live in the index, so #778's behavior was correct but undocumented. - FR-004: five -> six values; server_quarantined assigned by the discovery pass (not the classifier), name-only, description/schema withheld; config-denied tools skipped by the pass. - FR-003: note the name-only exception for quarantined entries. - Assumptions: quarantined tools are excluded from the index and enumerated from authoritative quarantine state. - contracts/mcp-deltas.md: add server_quarantined to the status enum + example response shape and remediation. - design doc taxonomy: five -> six, with the server_quarantined explanation. Related #778
Deploying mcpproxy-docs with
|
| Latest commit: |
de67b67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55038597.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://spec049-amend-on-main.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 28313018759 --repo smart-mcp-proxy/mcpproxy-go
|
![mcpproxy-gatekeeper[bot]](https://avatars.githubusercontent.com/u/216428285?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Gatekeeper approval — Codex review verdict: ACCEPT.
This approval is posted automatically by the MCPProxy Gatekeeper App on behalf of the Codex reviewer (verdict of record lives in the Paperclip review thread). Author≠approver satisfied; QA + CI gates enforced separately.
Auto-approved per Model B (MCP-1249).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns Spec 049 with PR #778 (community contribution by @electrolobzik), which surfaces quarantined tools in
retrieve_tools(include_disabled=true)as name-only locked entries and introduces a sixth disabled-tool status,server_quarantined.Spec 049 FR-004 pinned the status taxonomy to exactly five values and its Assumptions stated all locked tools live in the search index. #778's behavior is correct — quarantined tools are deliberately excluded from the index (TPA defense) and surfaced via a dedicated discovery pass — but was undocumented. This amendment makes the spec consistent so #778 can land.
Changes
server_quarantineddocumented as assigned by the quarantined-tool discovery pass (not the classifier), name-only, description/schema withheld; config-denied tools skipped;pending_approvalreused for tool-level pending/changed on trusted servers.contracts/mcp-deltas.md: addserver_quarantinedto the status enum + example response + remediation.Docs/spec only — no code change. Pairs with #778.
Related #778