Fix: items not dropping when clicking outside a container#1306
Open
Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Open
Fix: items not dropping when clicking outside a container#1306Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Alezito2008 wants to merge 1 commit intosmartcmd:mainfrom
Conversation
Contributor
Author
Minecraft.2026-03-16.21-26-12.mp4 |
m0zzaR
added a commit
to m0zzaR/MinecraftConsoles
that referenced
this pull request
Mar 17, 2026
Implemented a feature that allows players to toggle flying mode by pressing the 'H' key when the menu is not displayed and no screen is active. This change enhances gameplay by providing more control over player abilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where players were unable to drop items by clicking outside of the container boundaries.
Changes
Previous Behavior
Dragging an item outside the container screen and clicking would not drop the item
Root Cause
AbstractContainerMenu::clickedwould early return whenslotIndexwasSLOT_CLICKED_OUTSIDENew Behavior
Dragging an item outside the container screen and clicking now drops the item
Fix Implementation
Modified the boundary check in
AbstractContainerMenu::clickedto allow the function to continue if the index is equal toSLOT_CLICKED_OUTSIDEAI Use Disclosure
No
Related Issues