Open
Conversation
|
👋 poopoothegorilla, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
| // selectRandomRPCNode picks a random healthy node on every call without caching | ||
| // or terminating existing subscriptions on other nodes. | ||
| func (c *MultiNode[CHAIN_ID, RPC]) selectRandomRPCNode(ctx context.Context) (Node[CHAIN_ID, RPC], error) { | ||
| for { |
Contributor
There was a problem hiding this comment.
code duplication with lines 220-239
| func (s *randomRPCSelector[CHAIN_ID, RPC]) Select() Node[CHAIN_ID, RPC] { | ||
| var liveNodes []Node[CHAIN_ID, RPC] | ||
| for _, n := range s.nodes { | ||
| if n.State() == nodeStateAlive { |
Contributor
There was a problem hiding this comment.
If the node is not alive, we should terminate all subscriptions exceptthe alive loop UnsubscribeAllExceptAliveLoop()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RandomRPCnode selection mode that picks a random healthy RPC on everySelectRPCcall, bypassing the stickyactiveNodecacheUnsubscribeAllExceptAliveLoopwhen switching nodesMotivation
All existing selection modes are sticky —
selectNode()returns the cached active node as long as it's alive. This new mode distributes RPC calls across healthy nodes without tearing down subscriptions on rotation.Ref: PLEX-2537
Changes
node_selector.go: NewNodeSelectionModeRandomRPCconstant + factory registrationnode_selector_random_rpc.go: Selector usingmath/rand/v2to pick a random alive nodemulti_node.go:selectRandomRPCNode()path that skips activeNode caching and subscription teardown; lease check disabled for RandomRPC