pkg/solana/config: config enhancements#1222
Merged
Conversation
jmank88
force-pushed
the
CRE-361-configtest
branch
from
239d72a to
22d4217
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
22d4217 to
0532a55
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
0532a55 to
532a8f6
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
532a8f6 to
c333974
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
c333974 to
82424d4
Compare
Unheilbar
reviewed
Sep 5, 2025
|
|
||
| "github.com/smartcontractkit/chainlink-common/pkg/config" | ||
| commontypes "github.com/smartcontractkit/chainlink-common/pkg/types" | ||
| "github.com/smartcontractkit/chainlink-common/pkg/config/configtest" |
Contributor
There was a problem hiding this comment.
The name says 'test', which is a bit confusing, since its used here outside of test-suites
Contributor
Author
There was a problem hiding this comment.
Oh yeah that is historical baggage but there is a package configdoc now too that it be moved to.
jmank88
force-pushed
the
CRE-361-configtest
branch
from
8774dfe to
c8aaccb
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
CRE-361-configtest
branch
from
c8aaccb to
d727278
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
d727278 to
d8af57f
Compare
|
Unheilbar
approved these changes
Sep 5, 2025
Unheilbar
approved these changes
Sep 5, 2025
pavel-raykov
approved these changes
Sep 9, 2025
archseer
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-361
Requires:
Supports:
core ref: 901f1cbd90876144b8b37b0edeff08c31647e0bd