Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates Canton-related Docker images and fixes the Registry API URL structure. The changes bump the Splice Canton version from 0.5.3 to 0.5.11, upgrade supporting infrastructure images (Postgres from 14 to 18, Nginx from 1.27.0 to 1.29.5), expose the UserID field in participant endpoints for improved traceability, and correct the Registry URL by removing the /registry suffix from the base path (as it should be part of the API path, not the base URL).
Changes:
- Bump Canton Splice version from 0.5.3 to 0.5.11
- Upgrade Postgres image from version 14 to 18 and Nginx from 1.27.0 to 1.29.5
- Add UserID field to CantonParticipantEndpoints struct to expose user identity information
- Fix Registry API URL by removing
/registryfrom base path and update test accordingly
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/components/blockchain/canton/canton.go | Bumps Canton Splice version from 0.5.3 to 0.5.11 |
| framework/components/blockchain/canton/postgres.go | Updates Postgres image from version 14 to 18 |
| framework/components/blockchain/canton/nginx.go | Updates Nginx image from 1.27.0 to 1.29.5 |
| framework/components/blockchain/canton.go | Adds UserID field to participant endpoints, fixes Registry URL format, and refactors user ID handling |
| framework/examples/myproject/smoke_canton_test.go | Updates test to use corrected Registry URL path with /registry prefix |
| framework/.changeset/v0.14.3.md | Documents the changes in this release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Additionally, the global Scan service is accessible via: | ||
| // - http://scan.localhost:[PORT]/api/scan -> Scan API => https://docs.sync.global/app_dev/scan_api/index.html | ||
| // - http://scan.localhost:[PORT]/registry -> Token Standard API => https://docs.sync.global/app_dev/token_standard/index.html#api-references | ||
| // - http://scan.localhost:[PORT] -> Token Standard API => https://docs.sync.global/app_dev/token_standard/index.html#api-references |
There was a problem hiding this comment.
The comment alignment is inconsistent with excessive spaces between the URL and the arrow. The comment on line 74 has irregular spacing (multiple tabs/spaces) compared to line 73 and other similar comments in the documentation. This should be aligned consistently with the other lines.
| // - http://scan.localhost:[PORT] -> Token Standard API => https://docs.sync.global/app_dev/token_standard/index.html#api-references | |
| // - http://scan.localhost:[PORT] -> Token Standard API => https://docs.sync.global/app_dev/token_standard/index.html#api-references |
1 participant
This:
UserIDin the output/registryfrom the base pathBelow is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the Canton framework setup by updating the versions of the dependencies to include new features and bug fixes, expose user IDs for better traceability and JWT token association, and adjust the registry API URL for better alignment with the OpenAPI specification.
What
framework/.changeset/v0.14.3.mdframework/components/blockchain/canton.goUserIDfield toCantonParticipantEndpointsstruct to include the user ID associated with a participant, enhancing JWT token association./registrypath, aligning it with the OpenAPI spec and making the base URL point to the root.framework/components/blockchain/canton/canton.goSpliceVersionfrom0.5.3to0.5.11, incorporating new features and bug fixes.framework/components/blockchain/canton/nginx.go1.27.0to1.29.5, taking advantage of the latest improvements and security patches.framework/components/blockchain/canton/postgres.go14to18, ensuring compatibility with the latest database features and improvements.framework/examples/myproject/smoke_canton_test.go