Add active 1.6 NOPs to state for billing & Jira#21108
Add active 1.6 NOPs to state for billing & Jira#21108
Conversation
simsonraj
requested review from
0xAustinWang,
agusaldasoro,
asoliman92,
b-gopalswami,
matYang,
ogtownsend and
winder
|
👋 simsonraj, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds a filtered “active v1.6 NOPs” view to CCIP state output to support billing and Jira reporting.
Changes:
- Extend
CCIPViewwith a newV16Nopsfield exposed asv16Nopsin JSON - Generate the full NOPs view and additionally compute a v1.6-active subset (
filterNopsForV16) - Add an info-level log line during view generation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| deployment/ccip/view/view.go | Adds V16Nops to the exported CCIP JSON view model. |
| deployment/ccip/shared/stateview/view.go | Computes and attaches a filtered NOPs subset for v1.6 activity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, nil | ||
| } | ||
|
|
||
| // filiter nopsView to only NOPs active in V1.6 DONs with their V1.6 chain keys - this is needed for NOPs billing & NOPs JIRA |
There was a problem hiding this comment.
The function doc comment doesn’t follow Go conventions (should start with the function name) and contains a typo (“filiter”). Update it to start with filterNopsForV16 and correct the spelling (and consider “Jira” capitalization for consistency).
| // filiter nopsView to only NOPs active in V1.6 DONs with their V1.6 chain keys - this is needed for NOPs billing & NOPs JIRA | |
| // filterNopsForV16 filters nopsView to only NOPs active in V1.6 DONs with their V1.6 chain keys - this is needed for NOPs billing & NOPs Jira |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
1 participant
Requires
Supports