Skip to content

[DX-2826] use v2 contracts by default in the local CRE#21112

Open
Tofel wants to merge 1 commit intodevelopfrom
dx-2826-use-v2-contracts-by-default-local-cre
Open

[DX-2826] use v2 contracts by default in the local CRE#21112
Tofel wants to merge 1 commit intodevelopfrom
dx-2826-use-v2-contracts-by-default-local-cre

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Feb 11, 2026

No description provided.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cl-sonarqube-production
Copy link

@Tofel Tofel marked this pull request as ready for review February 11, 2026 17:37
@Tofel Tofel requested a review from a team as a code owner February 11, 2026 17:37
Copilot AI review requested due to automatic review settings February 11, 2026 17:37
@Tofel Tofel requested review from a team as code owners February 11, 2026 17:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local CRE tooling and system tests to use v2 registry contracts by default, while keeping an explicit opt-in path for legacy v1 coverage.

Changes:

  • Switched CRE CLI defaults (--with-contracts-version) from v1 to v2 and updated shell completions/help text accordingly.
  • Updated system test setup (and canary docs) to rely on the new v2 default, while forcing v1 explicitly where needed.
  • Adjusted CI workflows to start CRE with v1 only when required; otherwise rely on the v2 default.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
system-tests/tests/smoke/cre/v2_sharding_test.go Updates local run instructions to rely on default v2 contracts.
system-tests/tests/smoke/cre/v2_grpc_source_test.go Updates local run instructions to rely on default v2 contracts.
system-tests/tests/smoke/cre/cre_suite_test.go Forces v1 tests to use v1 explicitly; removes explicit v2 flags from v2 tests.
system-tests/tests/canaries_sentinels/README.md Docs now reflect v2 as default and explain opting into v1.
system-tests/lib/cre/types.go Updates default registry contract versions to v2 semvers.
core/scripts/cre/environment/environment/workflow.go Changes default --with-contracts-version to v2 for workflow commands.
core/scripts/cre/environment/environment/environment.go Changes default --with-contracts-version to v2 for env start.
core/scripts/cre/environment/completions.go Updates completion descriptions to reflect v2 default.
core/scripts/cre/environment/README.md Adds docs for opting into legacy v1 contracts and documents the flag.
.github/workflows/cre-system-tests.yaml CI now passes v1 explicitly when needed; relies on default v2 otherwise.
.github/workflows/cre-regression-system-tests.yaml Same as above for regression workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tofel Tofel requested a review from bolekk February 12, 2026 08:58
@Tofel Tofel enabled auto-merge February 12, 2026 10:05
@Tofel Tofel added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants