[DX-2826] use v2 contracts by default in the local CRE#21112
Open
[DX-2826] use v2 contracts by default in the local CRE#21112
Conversation
Contributor
|
I see you updated files related to
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the local CRE tooling and system tests to use v2 registry contracts by default, while keeping an explicit opt-in path for legacy v1 coverage.
Changes:
- Switched CRE CLI defaults (
--with-contracts-version) from v1 to v2 and updated shell completions/help text accordingly. - Updated system test setup (and canary docs) to rely on the new v2 default, while forcing v1 explicitly where needed.
- Adjusted CI workflows to start CRE with v1 only when required; otherwise rely on the v2 default.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/smoke/cre/v2_sharding_test.go | Updates local run instructions to rely on default v2 contracts. |
| system-tests/tests/smoke/cre/v2_grpc_source_test.go | Updates local run instructions to rely on default v2 contracts. |
| system-tests/tests/smoke/cre/cre_suite_test.go | Forces v1 tests to use v1 explicitly; removes explicit v2 flags from v2 tests. |
| system-tests/tests/canaries_sentinels/README.md | Docs now reflect v2 as default and explain opting into v1. |
| system-tests/lib/cre/types.go | Updates default registry contract versions to v2 semvers. |
| core/scripts/cre/environment/environment/workflow.go | Changes default --with-contracts-version to v2 for workflow commands. |
| core/scripts/cre/environment/environment/environment.go | Changes default --with-contracts-version to v2 for env start. |
| core/scripts/cre/environment/completions.go | Updates completion descriptions to reflect v2 default. |
| core/scripts/cre/environment/README.md | Adds docs for opting into legacy v1 contracts and documents the flag. |
| .github/workflows/cre-system-tests.yaml | CI now passes v1 explicitly when needed; relies on default v2 otherwise. |
| .github/workflows/cre-regression-system-tests.yaml | Same as above for regression workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchain0
approved these changes
Feb 13, 2026
bolekk
approved these changes
Feb 13, 2026
kdihalas
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





No description provided.