Skip to content

Conversation

@bolekk
Copy link
Contributor

@bolekk bolekk commented Feb 11, 2026

No description provided.

trunk-io[bot]

This comment was marked as outdated.

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch from e8357ff to c926626 Compare February 11, 2026 20:47
@trunk-io
Copy link

trunk-io bot commented Feb 11, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch 5 times, most recently from 1632a03 to 37a37fd Compare February 11, 2026 23:06
trunk-io[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

trunk-io[bot]

This comment was marked as outdated.

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch from 9342e07 to 4a579c0 Compare February 12, 2026 01:40
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

CORA - Analysis Skipped

Reason: The number of code owners (2) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (1) is less than the minimum required (2).

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch 2 times, most recently from fb60c21 to 4d9a227 Compare February 12, 2026 01:46
trunk-io[bot]

This comment was marked as outdated.

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch from 4d9a227 to 5a18f78 Compare February 12, 2026 02:20
@bolekk bolekk marked this pull request as ready for review February 12, 2026 02:20
@bolekk bolekk requested review from a team as code owners February 12, 2026 02:20
trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

DylanTinianov
DylanTinianov previously approved these changes Feb 12, 2026
UseCapRegOCRConfig bool

// Used only by LocalCRE
OverrideOCR3Config *ocr3.OracleConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want to change this struct to handle local CRE's special case we could follow this route:

  • add one more field to:
type PreEnvStartupOutput struct {
	DONCapabilityWithConfig []keystone_changeset.DONCapabilityWithConfig
    CapabilityToOCR3Config map[cre.CapabilityFlag]OCR3Config`
}
  • and return the config we want to use for each capability that requires it
  • then add CapabilityToOCR3Config map[cre.CapabilityFlag]OCR3Config to:
type ConfigureCapabilityRegistryInput struct {
	ChainSelector               uint64
	Topology                    *Topology
	CldEnv                      *cldf.Environment
	NodeSets                    []*NodeSet
	CapabilityRegistryConfigFns []CapabilityRegistryConfigFn
	Blockchains                 []blockchains.Blockchain

	CapabilitiesRegistryAddress *common.Address

	WithV2Registries bool

	DONCapabilityWithConfigs map[uint64][]keystone_changeset.DONCapabilityWithConfig
    CapabilityToOCR3Config map[cre.CapabilityFlag]OCR3Config
}
  • and pass that to func ConfigureCapabilityRegistry(input cre.ConfigureCapabilityRegistryInput), which inside calls mustToV2ConfigureInput()
  • finally modify `mustToV2ConfigureInput():
func (d *dons) mustToV2ConfigureInput(chainSelector uint64, contractAddress string, capabilityToOCR3Config map[cre.CapabilityFlag]OCR3Config) cap_reg_v2_seq.ConfigureCapabilitiesRegistryInput {
  • and grab if from the map when executing embedOCR3Config()

@bolekk bolekk force-pushed the local_cre_more_ocr_in_capreg branch from 630e3fa to 70154eb Compare February 12, 2026 18:47
@cl-sonarqube-production
Copy link

Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Unrelated Failure

Affected failures:

  1. Workflow Run: Integration Tests

What Broke

The TestToV2ConfigureInput in keystone_test.go is incorrectly passing a nil OCR3 configuration map when a capability is configured to use it, leading to a panic. Specifically, the test's donConfig includes a capability with UseCapRegOCRConfig: true, which causes dons.mustToV2ConfigureInput to attempt to look up an OCR3 config in the nil map, resulting in a panic.

Autofix Options

You can use our MCP server to get AI assistance with debugging and fixing these failures.

  • Use MCP in your IDE to debug the issue. Try Help me fix CI failures from FbwI86Qm to get started.

Tip

Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.

@bolekk bolekk enabled auto-merge February 13, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants