LDAP / OIDC Auth: update DeleteAuthToken query based on table schema #21125
Conversation
|
👋 harry-anderson, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
I see you updated files related to
|
|
| } | ||
|
|
||
| // Remove any existing API tokens | ||
| if _, err = l.ds.ExecContext(ctx, "DELETE FROM ldap_user_api_tokens WHERE user_email = $1", user.Email); err != nil { |
There was a problem hiding this comment.
can we change DeleteAuthToken to just take user_emails and call it from other places like this?
There was a problem hiding this comment.
Not sure what you mean @pavel-raykov, can you provide example?
There was a problem hiding this comment.
I've thought this deletion routine is shared from other places, but as you mentioned - they have a different table (users and not ldap_user_api_tokens). So nothing to do here.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
DeleteAuthToken