Skip to content

[DX-2790] add a big sharding topology#21129

Open
Tofel wants to merge 1 commit intodevelopfrom
dx-2790-extra-sharding-topology
Open

[DX-2790] add a big sharding topology#21129
Tofel wants to merge 1 commit intodevelopfrom
dx-2790-extra-sharding-topology

Conversation

@Tofel
Copy link
Contributor

@Tofel Tofel commented Feb 12, 2026

No description provided.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Feb 12, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@Tofel Tofel marked this pull request as ready for review February 12, 2026 16:49
@Tofel Tofel requested review from a team as code owners February 12, 2026 16:49
@Tofel Tofel requested review from Copilot and mchain0 February 12, 2026 16:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new CRE environment TOML config for running a larger sharded workflow-gateway topology.

Changes:

  • Introduces a new environment config with two Anvil chains and a Job Distributor image.
  • Defines multiple workflow “shard” DON nodesets plus a bootstrap/gateway nodeset.
  • Configures node Docker build parameters, DB containers, and selected exposed ports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


[[blockchains]]
type = "anvil"
chain_id = "1337"
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain_id is configured as a string while supported_evm_chains uses integers. If the config loader expects consistent types, this can break chain matching/selection. Consider making chain_id numeric (no quotes) or making supported_evm_chains strings to match.

Copilot uses AI. Check for mistakes.

[[blockchains]]
type = "anvil"
chain_id = "2337"
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain_id is configured as a string while supported_evm_chains uses integers. If the config loader expects consistent types, this can break chain matching/selection. Consider making chain_id numeric (no quotes) or making supported_evm_chains strings to match.

Copilot uses AI. Check for mistakes.
http_port_range_start = 10300

env_vars = { CL_EVM_CMD = "" }
supported_evm_chains = [1337, 2337]
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain_id is configured as a string while supported_evm_chains uses integers. If the config loader expects consistent types, this can break chain matching/selection. Consider making chain_id numeric (no quotes) or making supported_evm_chains strings to match.

Copilot uses AI. Check for mistakes.
Comment on lines +200 to +204
[[nodesets]]
nodes = 4
name = "shard5"
don_types = ["workflow", "shard"]
shard_index = 5
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename indicates “sharded-5-dons”, but the config defines shard0 through shard5 (6 shard DONs). Rename the file to reflect the actual shard count or adjust the topology to match the “5 dons” naming.

Copilot uses AI. Check for mistakes.
@Tofel Tofel force-pushed the dx-2790-extra-sharding-topology branch from adc5d63 to ae61787 Compare February 13, 2026 07:47
@Tofel Tofel force-pushed the dx-2790-extra-sharding-topology branch from ae61787 to 48c7f5d Compare February 13, 2026 07:48
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant