Skip to content

[PRODCRE-1746] Make keys folder self-contained.#21130

Open
pavel-raykov wants to merge 7 commits intodevelopfrom
move-internal
Open

[PRODCRE-1746] Make keys folder self-contained.#21130
pavel-raykov wants to merge 7 commits intodevelopfrom
move-internal

Conversation

@pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Feb 12, 2026

  • Move RequireEqualKeys to exporttestutils (last non-keys usage of internal.Raw)
  • Inlined concatBytes into ocr2key
  • Inlined mustRandBytes into evm_keyring_test
  • Extracted type Sha256Hash into a separate sha256 file.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@pavel-raykov pavel-raykov marked this pull request as ready for review February 12, 2026 16:18
@pavel-raykov pavel-raykov requested review from a team as code owners February 12, 2026 16:18
Copilot AI review requested due to automatic review settings February 12, 2026 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the keystore keys folder more self-contained by moving shared test helpers into keys utilities and inlining previously shared helpers/types into the ocr2key package.

Changes:

  • Moved requireEqualKeys from keystore tests into core/services/keystore/keys as RequireEqualKeys
  • Inlined Sha256Hash / EmptySha256Hash into ocr2key and updated keyBundle raw migration logic accordingly
  • Inlined ConcatBytes and MustRandBytes equivalents into ocr2key

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
core/store/models/common.go Removes EmptySha256Hash from shared models to reduce cross-package dependencies.
core/services/keystore/workflow_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/tron_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/ton_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/sui_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/starknet_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/solana_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/master_test.go Removes local requireEqualKeys helper (now centralized in keys).
core/services/keystore/keys/ocr2key/ton_keyring.go Replaces utils.ConcatBytes with package-local concatBytes.
core/services/keystore/keys/ocr2key/key_bundle.go Replaces models.Sha256Hash usage with ocr2key.Sha256Hash.
core/services/keystore/keys/ocr2key/generic_key_bundle.go Introduces local Sha256Hash / EmptySha256Hash and updates migration empty-ID detection.
core/services/keystore/keys/ocr2key/evm_keyring_test.go Inlines random-bytes test helper used for config digest/report generation.
core/services/keystore/keys/ocr2key/ed25519_keyring.go Replaces utils.ConcatBytes with local concatBytes implementation.
core/services/keystore/keys/ocr2key/cosmos_keyring.go Replaces utils.ConcatBytes with package-local concatBytes.
core/services/keystore/keys/exporttestutils.go Adds exported RequireEqualKeys helper for cross-test reuse.
core/services/keystore/eth_test.go Switches key equality assertion to keys.RequireEqualKeys (imported with alias).
core/services/keystore/dkgrecipient_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/cosmos_test.go Switches key equality assertion to keys.RequireEqualKeys.
core/services/keystore/aptos_test.go Switches key equality assertion to keys.RequireEqualKeys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pavel-raykov pavel-raykov requested a review from jmank88 February 12, 2026 16:21
@pavel-raykov pavel-raykov marked this pull request as draft February 12, 2026 16:39
@pavel-raykov
Copy link
Collaborator Author

.cora

@pavel-raykov pavel-raykov requested a review from Copilot February 12, 2026 16:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trunk-io
Copy link

trunk-io bot commented Feb 12, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link

@pavel-raykov pavel-raykov marked this pull request as ready for review February 12, 2026 17:37
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 12, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2026
* Minor.

* Minor.

* Minor.

* Minor.

* Minor.

* Minor.

* Minor.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@pavel-raykov pavel-raykov removed this pull request from the merge queue due to a manual request Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@Galaxysurfer2034
Copy link

Galaxysurfer2034 commented Feb 13, 2026 via email

@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@pavel-raykov pavel-raykov removed this pull request from the merge queue due to a manual request Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@kalverra kalverra removed this pull request from the merge queue due to a manual request Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@pavel-raykov pavel-raykov removed this pull request from the merge queue due to a manual request Feb 13, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Feb 13, 2026
@Tofel Tofel removed this pull request from the merge queue due to a manual request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants