[PRODCRE-1746] Make keys folder self-contained.#21130
[PRODCRE-1746] Make keys folder self-contained.#21130pavel-raykov wants to merge 7 commits intodevelopfrom
Conversation
|
I see you updated files related to
|
There was a problem hiding this comment.
Pull request overview
This PR makes the keystore keys folder more self-contained by moving shared test helpers into keys utilities and inlining previously shared helpers/types into the ocr2key package.
Changes:
- Moved
requireEqualKeysfromkeystoretests intocore/services/keystore/keysasRequireEqualKeys - Inlined
Sha256Hash/EmptySha256Hashintoocr2keyand updatedkeyBundleraw migration logic accordingly - Inlined
ConcatBytesandMustRandBytesequivalents intoocr2key
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/store/models/common.go | Removes EmptySha256Hash from shared models to reduce cross-package dependencies. |
| core/services/keystore/workflow_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/tron_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/ton_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/sui_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/starknet_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/solana_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/master_test.go | Removes local requireEqualKeys helper (now centralized in keys). |
| core/services/keystore/keys/ocr2key/ton_keyring.go | Replaces utils.ConcatBytes with package-local concatBytes. |
| core/services/keystore/keys/ocr2key/key_bundle.go | Replaces models.Sha256Hash usage with ocr2key.Sha256Hash. |
| core/services/keystore/keys/ocr2key/generic_key_bundle.go | Introduces local Sha256Hash / EmptySha256Hash and updates migration empty-ID detection. |
| core/services/keystore/keys/ocr2key/evm_keyring_test.go | Inlines random-bytes test helper used for config digest/report generation. |
| core/services/keystore/keys/ocr2key/ed25519_keyring.go | Replaces utils.ConcatBytes with local concatBytes implementation. |
| core/services/keystore/keys/ocr2key/cosmos_keyring.go | Replaces utils.ConcatBytes with package-local concatBytes. |
| core/services/keystore/keys/exporttestutils.go | Adds exported RequireEqualKeys helper for cross-test reuse. |
| core/services/keystore/eth_test.go | Switches key equality assertion to keys.RequireEqualKeys (imported with alias). |
| core/services/keystore/dkgrecipient_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/cosmos_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
| core/services/keystore/aptos_test.go | Switches key equality assertion to keys.RequireEqualKeys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
.cora |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
* Minor. * Minor. * Minor. * Minor. * Minor. * Minor. * Minor.
|
DONt have time. Swing that one for me Pavel. Also protect status must be
initiative In core repository again. 2-Factory blowout.
…On Fri, Feb 13, 2026, 2:26 AM pavel-raykov ***@***.***> wrote:
#21130 <#21130> was
added to the merge queue
<https://github.com/smartcontractkit/chainlink/queue/develop>.
—
Reply to this email directly, view it on GitHub
<#21130 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJR4SABJ6YNQNJU7RNMQBP34LWDENAVCNFSM6AAAAACU5FKANWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSG42TSMZQGEYTENA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|




Uh oh!
There was an error while loading. Please reload this page.