Skip to content

style: clear standards-check lint debt (8x SC2312, 1x MD041) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twistedmelonman merged 2 commits into from
Sep 9, 2026
Merged

style: clear standards-check lint debt (8x SC2312, 1x MD041) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47aee0d
style: make install.sh shellcheck-clean at -S info and LICENSE.md MD0…
Sep 9, 2026
ca1a381
docs: explain why the SC2312 `|| true` guards are inert at four call …
Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MIT License
# MIT License

Copyright (c) 2026 Andrew Rich

Expand Down
25 changes: 17 additions & 8 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ parse_args() {
# Prerequisite checks
# ---------------------------------------------------------------------------
check_os() {
[[ "$(uname -s)" == "Darwin" ]] || fatal "This script only supports macOS."
[[ "$(uname -s || true)" == "Darwin" ]] || fatal "This script only supports macOS."
}

check_root() {
Expand Down Expand Up @@ -274,7 +274,9 @@ do_update_mirrors() {

# Read current list for comparison
if [[ -f "$LOCAL_MIRRORS_FILE" ]]; then
mapfile -t current_domains < <(parse_mirrors_file "$LOCAL_MIRRORS_FILE")
# parse_mirrors_file always exits 0 (its pipeline ends in `|| true`). The `|| true` below satisfies SC2312 and changes
# nothing: process substitution never propagates status under `set -e`.
mapfile -t current_domains < <(parse_mirrors_file "$LOCAL_MIRRORS_FILE" || true)
else
current_domains=()
fi
Expand Down Expand Up @@ -320,7 +322,7 @@ do_update_mirrors() {
echo "# The first non-comment line is the primary domain (others become symlinks)."
echo "#"
echo "# Source: https://en.wikipedia.org/wiki/Archive.today"
echo "# Updated: $(date -u '+%Y-%m-%dT%H:%M:%SZ')"
echo "# Updated: $(date -u '+%Y-%m-%dT%H:%M:%SZ' || true)"
printf '%s\n' "${new_domains[@]}"
} >"$LOCAL_MIRRORS_FILE"

Expand Down Expand Up @@ -390,7 +392,7 @@ write_manifest() {
fi
{
echo "# ${MANAGED_MARKER}"
echo "# Updated: $(date -u '+%Y-%m-%dT%H:%M:%SZ')"
echo "# Updated: $(date -u '+%Y-%m-%dT%H:%M:%SZ' || true)"
printf '%s\n' "${domains[@]}"
} >"$MANIFEST_FILE"
}
Expand All @@ -410,7 +412,7 @@ is_managed() {

is_correct_symlink() {
local link="$1" target="$2"
[[ -L "$link" ]] && [[ "$(readlink "$link")" == "$target" ]]
[[ -L "$link" ]] && [[ "$(readlink "$link" || true)" == "$target" ]]
}

primary_is_current() {
Expand Down Expand Up @@ -517,7 +519,9 @@ apply_removals() {
do_uninstall() {
info "Uninstalling ${SCRIPT_NAME}..."
local -a managed
mapfile -t managed < <(read_manifest)
# read_manifest always exits 0 (its grep ends in `|| true`). The `|| true` below satisfies SC2312 and changes
# nothing: process substitution never propagates status under `set -e`.
mapfile -t managed < <(read_manifest || true)

if [[ ${#managed[@]} -eq 0 ]]; then
warn "No managed resolver files found (manifest missing or empty)."
Expand Down Expand Up @@ -588,7 +592,10 @@ main() {

check_resolver_dir

mapfile -t DESIRED_DOMAINS < <(get_desired_mirrors)
# get_desired_mirrors either prints or calls fatal; it never returns
# nonzero. The `|| true` below satisfies SC2312 and changes
# nothing: process substitution never propagates status under `set -e`.
mapfile -t DESIRED_DOMAINS < <(get_desired_mirrors || true)

if [[ ${#DESIRED_DOMAINS[@]} -eq 0 ]]; then
fatal "Mirror list is empty. Cannot continue."
Expand All @@ -600,7 +607,9 @@ main() {
info "Mirrors total : ${#DESIRED_DOMAINS[@]}"
echo >&2

mapfile -t MANIFEST_DOMAINS < <(read_manifest)
# read_manifest always exits 0 (its grep ends in `|| true`). The `|| true` below satisfies SC2312 and changes
# nothing: process substitution never propagates status under `set -e`.
mapfile -t MANIFEST_DOMAINS < <(read_manifest || true)

local install_changes removal_changes total_changes
install_changes="$(apply_install "${DESIRED_DOMAINS[@]}")"
Expand Down
Loading