chore: sync .claude extension template to dev-env#102 - #8
Merged
Conversation
Wave 3 of the standards-check rollout. This repo failed shellcheck on a single file: .claude/hooks/extensions/example.sh.disabled, a copied template that is never executed (the .disabled suffix is what keeps the global hook from sourcing it). The findings were SC2155, SC2329, and SC2312 in that template — all already fixed upstream in smartwatermelon/dev-env#102. The copy here is byte-identical to dev-env at 404218c, the revision immediately before that fix, so this is a pure forward update to a file that was already reviewed and merged there, not a local edit. Provenance was verified rather than assumed: the md5 of this file matches exactly one revision in dev-env's history for that path. Verified with the CI runner rather than the linter alone: run-standards.sh --repo <this repo> now exits 0 with no errors from any of the six linters. Six fleet repos carry the same stale copy, and repo-template does too, so new repos are born failing standards-check. There is no propagation mechanism for .claude/; that root cause is smartwatermelon/dev-env#62. Claude-Session: https://claude.ai/code/session_01UaPoEix1iED8ENCZCa12jy
This comment has been minimized.
This comment has been minimized.
|
This is an example/template shell hook (disabled by default). The changes improve documentation and fix shell scripting issues:
No impact on production or the skill artifact (SKILL.md). VERDICT: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
This repo failed
standards-checkon shellcheck only.The shellcheck findings were not this repo's code
Every shellcheck finding was in
.claude/hooks/extensions/example.sh.disabled— a copied template that is never executed (the
.disabledsuffix is whatstops the global hook sourcing it). The findings (SC2155, SC2329, SC2312) were
already fixed upstream in smartwatermelon/dev-env#102.
Provenance verified, not assumed: this file's md5 matches dev-env at
404218cexactly — the revision immediately before that fix. So this is apure forward update to an already-reviewed, already-merged file, not an edit
someone made locally.
Verification
The same runner was run before the fix as a known-bad control and
reproduced these exact findings.
Wider finding
Six fleet repos carry this identical stale template, and
repo-templatedoestoo — so every new repo is born failing
standards-check. There is nopropagation mechanism for
.claude/; that root cause issmartwatermelon/dev-env#62.
Scope
Wave 3 of the fleet standards-check rollout, round 2. Round 1 (four repos)
merged green earlier today.
https://claude.ai/code/session_01UaPoEix1iED8ENCZCa12jy