Skip to content

it's a start. congrats! =D#25

Merged
chrisgbaker merged 1 commit into
masterfrom
for_colin
Jan 10, 2020
Merged

it's a start. congrats! =D#25
chrisgbaker merged 1 commit into
masterfrom
for_colin

Conversation

@chrisgbaker

Copy link
Copy Markdown
Contributor

While it IS my favorite part of standup to watch @woolsox furiously lower the volume, I figured this might make it a bit easier.

Untested however; I don't have maestro setup locally, and not the best at bash. So, tear it apart!

@dkniffin

dkniffin commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

I love this idea, but not 100% sold on how it's implemented here. spotify.sh is our copy of shpotify, so I don't want to make changes directly to that if we can avoid it.

The two options I would be okay with are:

  1. (preferred) Open a PR over there, and if they accept it, then we can pull it back in here
  2. Implement this in the ruby layer instead, so it'd become /maestro fadeout and that would repeatedly run spotify.sh vol down until it's at 0.

@chrisgbaker

Copy link
Copy Markdown
Contributor Author

@dkniffin hnarayanan/shpotify#121 We'll see if he wants this merged as well

@hnarayanan

Copy link
Copy Markdown

Let me try to understand what is going on. The code change seems light enough, but once I understand what you're trying to do better I will merge it.

@dkniffin

Copy link
Copy Markdown
Contributor

@hnarayanan Awesome, thank you.

Side-note: Any chance we could have maestro mentioned somewhere in the shpotify readme as a "this thing uses shpotify, go check it out" kind of thing?

@hnarayanan

Copy link
Copy Markdown

Even better, if you could come up with a list of handful of projects that embed shpotify (I know oh-my-zsh is one of them), then I will make a dedicated section of the README to apps that build on it.

@dkniffin

Copy link
Copy Markdown
Contributor

@hnarayanan hnarayanan/shpotify#122 The only one I could find is the oh-my-zsh plugin

@chrisgbaker
chrisgbaker merged commit 5cc6af2 into master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants