Skip to content

Use display value for echart axis labels #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leonardo-Signorelli merged 2 commits into from
Jul 31, 2026
Merged

Use display value for echart axis labels #2893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce51e24
Use display value for echart axis labels
lucafoscili Jul 30, 2026
ca48dfc
Update unit-test.yaml
lucafoscili Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/unit-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
group: generate-docs-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v5
uses: actions/setup-node@v5
with:
node-version: '22.16.0'
cache: 'yarn'
Expand Down
11 changes: 11 additions & 0 deletions packages/ketchup/src/components/kup-data-table/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,17 @@ Type: `Promise<void>`



### `copyCellValueInColumn() => Promise<void>`

Copies the value of the currently focused cell to all visible rows in the same column.
Only cell types included in TypesToDuplicate are supported.

#### Returns

Type: `Promise<void>`



### `defaultSortingFunction(columns: KupDataColumn[], receivingColumnIndex: number, sortedColumnIndex: number, useNewObject?: boolean) => Promise<KupDataColumn[]>`


Expand Down
15 changes: 11 additions & 4 deletions packages/ketchup/src/components/kup-echart/kup-echart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ import { KupDebugCategory } from '../../managers/kup-debug/kup-debug-declaration
import { KupThemeColorValues } from '../../managers/kup-theme/kup-theme-declarations';
import { getProps, setProps } from '../../utils/utils';
import { componentWrapperId } from '../../variables/GenericVariables';
import { getColumnByName } from '../../utils/cell-utils';
import {
getCellValueForDisplay,
getColumnByName,
} from '../../utils/cell-utils';
import {
KupDataColumn,
KupDataDataset,
Expand Down Expand Up @@ -858,9 +861,10 @@ export class KupEchart {
for (let i = 0; i < dataset.rows.length; i++) {
const cells = dataset.rows[i].cells;
const treatedCells: KupDataRowCells = {};
const title = getColumnByName(dataset.columns, this.axis).title;
const column = getColumnByName(dataset.columns, this.axis);
const title = column.title;
treatedCells[title] = cells[this.axis];
x.push(treatedCells[title].value);
x.push(getCellValueForDisplay(column, treatedCells[title]));
}
}
return x;
Expand Down Expand Up @@ -935,7 +939,10 @@ export class KupEchart {
return y;
}
for (const row of this.data.rows) {
const title = row.cells[this.axis]?.value ?? '[not found]';
const axisCell = row.cells[this.axis];
const title = axisCell
? getCellValueForDisplay(column, axisCell)
: '[not found]';
for (const key of Object.keys(row.cells)) {
if (
!this.series ||
Expand Down
Loading