Skip to content

Implement scrollback for RPC console #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7415963987456321 wants to merge 1 commit into from
Closed

Implement scrollback for RPC console #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/qt/rpcconsole.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
#include <QThread>
#include <QTime>

// TODO: add a scrollback limit, as there is currently none
// TODO: make it possible to filter out categories (esp debug messages when implemented)
// TODO: receive errors and debug messages through ClientModel

const int CONSOLE_HISTORY = 50;
const int CONSOLE_SCROLLBACK = 100;
const QSize ICON_SIZE(24, 24);

const int INITIAL_TRAFFIC_GRAPH_MINS = 30;
Expand Down Expand Up @@ -202,6 +202,9 @@ RPCConsole::RPCConsole(QWidget *parent) :
ui->lineEdit->installEventFilter(this);
ui->messagesWidget->installEventFilter(this);

// Set scrollback size
ui->messagesWidget->document()->setMaximumBlockCount(CONSOLE_SCROLLBACK);

connect(ui->clearButton, SIGNAL(clicked()), this, SLOT(clear()));
connect(ui->btnClearTrafficGraph, SIGNAL(clicked()), ui->trafficGraph, SLOT(clear()));

Expand Down Expand Up @@ -346,6 +349,7 @@ void RPCConsole::message(int category, const QString &message, bool html)
out += message;
else
out += GUIUtil::HtmlEscape(message, true);

out += "</td></tr></table>";
ui->messagesWidget->append(out);
}
Expand Down