Added support for FlashLFQParameters#161
Open
Alexander-Sol wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current master of mzLib has FlashLFQ refactored such that parameters are stored in a new FlashLfqParameters class.
This PR enables FlashLFQ to work with the latest version of mzLib without breaking.
However, the integrations of the FlashLfqSettings in FlashLFQ and the FlashLfqParameters class in mzLib/FlashLFQ is clumsy. It's working, but the future directoin is to integrate this more seamlessly. FlashLFQ should be able to write/read FlashLfqParameters to/from .toml files, instead of having a custom .toml for FlashLfqSettings
Also, this PR references a local version of mzLib, so it won't run on appveyor/github actions. To use the code, you'll have to update the mzLib reference