Quant interfaces#985
Open
Alexander-Sol wants to merge 2 commits into
Open
Conversation
…nce new MedianPolishStrategy
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 81.09% 81.08% -0.02%
==========================================
Files 271 274 +3
Lines 39144 39230 +86
Branches 4292 4303 +11
==========================================
+ Hits 31744 31808 +64
- Misses 6650 6667 +17
- Partials 750 755 +5
🚀 New features to boost your workflow:
|
nbollis
reviewed
Dec 3, 2025
Member
nbollis
left a comment
nbollis
left a comment
There was a problem hiding this comment.
What about the interface that is already in readers? How does this play into this?
| /// <summary> | ||
| /// The peptide sequence | ||
| /// </summary> | ||
| string Sequence { get; } |
Member
There was a problem hiding this comment.
We should probably use BaseSequence or FullSequence so it maps better with our existing objects.
| /// <summary> | ||
| /// The filename without extension | ||
| /// </summary> | ||
| string FilenameWithoutExtension { get; } |
Member
There was a problem hiding this comment.
Love the dependency injection and inversion of control here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.