Skip to content

feat: Restore instance-level plugins#347

Open
jterapin wants to merge 2 commits into
mainfrom
restore-instance-level-plugins
Open

feat: Restore instance-level plugins#347
jterapin wants to merge 2 commits into
mainfrom
restore-instance-level-plugins

Conversation

@jterapin

@jterapin jterapin commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Context

Restores V3 behavior lost in the V4 rewrite:

client = Service::Client.new(plugins: [MyPlugin])  # scoped to this client
  • Single-pass only; plugins can't inject other plugins (deliberate vs V3).
  • String-name fixrequire_plugin resolves constants from the global namespace (Kernel) instead of Smithy::Client::Plugin, so a string-named plugin colliding with a constant under Plugin no longer mis-resolves.

Other Notes

  • De-dup matches V3 (by object identity): a class vs. its instance, and two instances of one class, are not deduped. Per-class uniqueness is a separate discussion, out of scope here. I made a TODO for a visit later with the team.

@jterapin jterapin marked this pull request as ready for review July 7, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant