fix(api): correct slide_match call in FastAPI server#308
Open
felixtsu wants to merge 1 commit intosml2h3:masterfrom
Open
fix(api): correct slide_match call in FastAPI server#308felixtsu wants to merge 1 commit intosml2h3:masterfrom
felixtsu wants to merge 1 commit intosml2h3:masterfrom
Conversation
DdddOcr.slide_match expects positional target_img/background_img (or compatible positional bytes). Using target_bytes/background_bytes caused TypeError at runtime; flag is not supported by slide_match and was removed from the call. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/slide_matchendpoint inddddocr/api/app.pycalledDdddOcr.slide_matchwith keyword argumentstarget_bytesandbackground_bytes, which do not exist onslide_match(the API usestarget_img/background_imgas the first two positional parameters). This caused aTypeErrorat runtime when hitting the endpoint.Also removed the
flag=argument, which is not accepted byslide_matchanywhere in the stack.Change
Align the call with
routes.py/mcp.py: pass decoded image bytes positionally and only forwardsimple_target.The
flagfield remains onSlideMatchRequestfor request-schema compatibility; it is simply not passed through until the library defines behavior for it.Made with Cursor