ci: lint workflows with actionlint - #23
Merged
Merged
Conversation
Workflow changes had no automated check: a YAML parse proved the file loads, but nothing caught unknown context properties, invalid expressions, undefined step outputs or shell problems inside run blocks. Adds a job running the upstream actionlint container over the repository on every push and pull request that touches .github/workflows. The workflow lints itself, so its own pull-request run is the proof. Closes #22 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The first run reported 19 findings, all from shellcheck and none from actionlint itself. SC2016 fires on the single-quoted jq programs, which must stay literal. SC2129 is pure style. SC2155 warns about a masked return value in blocks that run without set -e and already fall back with || echo "". Everything else stays enabled. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Problem
A change to any workflow under
.github/workflows/had no automated check. A YAML parse proves the file loads, but it does not catch whatactionlintexists to find: unknown context properties, invalid${{ }}expressions, undefined step or job outputs, wrongruns-onlabels, and shell problems insiderun:blocks. #21 had to be verified by hand, event name by event name, for exactly this reason.Change
One new workflow,
lint_workflows.yaml. It runs the upstreamrhysd/actionlintcontainer over the repository onpushtomain, onpull_request, and onworkflow_dispatch, filtered to.github/workflows/**so it stays quiet for unrelated changes.The image tag is pinned to
1.7.12rather thanlatest, so a new upstream release cannot turn a green pull request red without a commit here.The workflow lints itself: this pull request touches the filtered path, so its own run is the acceptance evidence, and it also lints the three existing workflows for the first time.
What is not in this change
No local installation instructions.
actionlintin CI does not depend on whoever edits a workflow having the tool installed, which is the half of #22 that actually makes the check reliable. A local setup note can follow if it turns out to be wanted.🤖 Generated with Claude Code