fix(auth): preserve Plex sessions on HTTP - #84
Closed
snapetech wants to merge 1 commit into
Closed
Conversation
|
Hey @snapetech, thanks for submitting this PR! However, it looks like the PR template hasn't been fully filled out. Issues found:
Please update your PR description to follow the PR template. This check will automatically re-run when you edit your PR description. |
Owner
Author
|
Closing this draft; the owner requested a direct push to main instead of a pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore transport-aware session cookies so Plex sign-in works on direct HTTP/LAN deployments while HTTPS deployments continue to receive
Securecookies. The login page now verifies/auth/meafter the Plex exchange and clears the spinner with an actionable error when the browser session was not established.The root cause was an unconditional
secure: trueoverride at the session sink. The browser rejected that cookie onkspls0:5055, so the UI never observed an authenticated user. The maintainer decision record explicitly says not to reintroduce that setting until HTTP is removed behind a verified HTTPS migration.How Has This Been Tested?
kspls0verification passed over direct HTTP and HTTPS: Plex exchange returned 200, the expected cookie attributes were emitted, and/auth/mereturned user 1.Screenshots / Logs (if applicable)
Live verification confirmed the direct HTTP cookie is not
Secure, the HTTPS cookie isSecure, and both authenticated sessions returned user 1.Release Notes
release-notes/.pnpm release-notes:preview.Checklist:
pnpm buildpnpm i18n:extract