Skip to content

feat: add room temperature source telemetry - #331

Open
afathman wants to merge 1 commit into
snazzybean:mainfrom
afathman:feat/temp-source-telemetry
Open

feat: add room temperature source telemetry#331
afathman wants to merge 1 commit into
snazzybean:mainfrom
afathman:feat/temp-source-telemetry

Conversation

@afathman

@afathman afathman commented May 29, 2026

Copy link
Copy Markdown

Summary

  • add per-room sensor health telemetry fields: temp_source and temp_age_seconds
  • thread telemetry through coordinator room processing and final room state payloads
  • extend coordinator snapshot/dropout tests for sensor, device, cache, and none source paths
  • update MPC preheating integration assertion to validate eco target resolution when no upcoming schedule blocks

Validation

  • pytest -q
  • ruff check .
  • mypy custom_components/roommind

Co-Authored-By: Abacus.AI CLI <agent@abacus.ai>
@afathman
afathman requested a review from snazzybean as a code owner May 29, 2026 20:12
@snazzybean

Copy link
Copy Markdown
Owner

The idea is nice, but as-is it only lands in the diagnostics snapshot, not in the history CSV, so it doesn't help much with the intermittent sensor dropouts I usually debug from. To make it worthwhile, please add temp_source to DETAIL_FIELDS so it's tracked over time, and drop temp_age_seconds (it's 0.0 in normal operation and duplicates the existing cached_temp_age_s).

Two things blocking merge regardless: CI Lint is red (coordinator.py needs ruff format), and the change to test_no_preheating_without_upcoming_blocks weakens an unrelated test that still passes, please revert that assertion.

Happy to merge once that's sorted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants