Skip to content

Update coc aa1 to master (Update CODE_OF_CONDUCT.md)#110

Open
pinterid wants to merge 2 commits into
masterfrom
update-coc-aa1
Open

Update coc aa1 to master (Update CODE_OF_CONDUCT.md)#110
pinterid wants to merge 2 commits into
masterfrom
update-coc-aa1

Conversation

@pinterid
Copy link
Copy Markdown
Member

@pinterid pinterid commented Aug 5, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently the COC does not pass Codacy.

What is the new behavior (if this is a feature change)?

  • Now the COC passes Codacy.

Other information:

  • Ref: 🐍

Improve code quality.
@pinterid pinterid added the documentation Improvements or additions to documentation label Aug 5, 2020
@pinterid pinterid self-assigned this Aug 5, 2020
Copy link
Copy Markdown
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge after a few changes.

Comment thread CODE_OF_CONDUCT.md Outdated
The title has been changed to title case.
@schettn schettn requested a review from kleberbaum August 8, 2020 11:09
Copy link
Copy Markdown
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants