fix: COM_StripExtension overflow and CG_CompileText heap churn/OOB write#82
Closed
Kr3m wants to merge 1 commit intosnems:masterfrom
Closed
fix: COM_StripExtension overflow and CG_CompileText heap churn/OOB write#82Kr3m wants to merge 1 commit intosnems:masterfrom
Kr3m wants to merge 1 commit intosnems:masterfrom
Conversation
- COM_StripExtension: add destsize parameter and reimplement using Q_strncpyz to avoid unbounded copy and undefined in‑place use. Update all cg_weapons.c call sites to pass sizeof(path). - CG_CompileText: replace per‑frame Z_Malloc scratch buffers with static arrays; cap input length at MAX_STRING_CHARS; add bounds check (i < OSP_TEXT_CMD_MAX - 1) to prevent command array overrun. CG_CompiledTextDestroy becomes a no‑op.
Contributor
Author
|
I might need to tune this a bit first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some crash issues with other mods and thought I'd share my fix.
COM_StripExtension: add destsize parameter and reimplement using Q_strncpyz to avoid unbounded copy and undefined in‑place use. Update all cg_weapons.c call sites to pass sizeof(path).
CG_CompileText: replace per‑frame Z_Malloc scratch buffers with static arrays; cap input length at MAX_STRING_CHARS; add bounds check (i < OSP_TEXT_CMD_MAX - 1) to prevent command array overrun. CG_CompiledTextDestroy becomes a no‑op.