Fix: segfault when connecting to a server with cg_oversampleMouse 1#83
Merged
snems merged 1 commit intosnems:masterfrom May 4, 2026
Merged
Fix: segfault when connecting to a server with cg_oversampleMouse 1#83snems merged 1 commit intosnems:masterfrom
snems merged 1 commit intosnems:masterfrom
Conversation
Owner
|
OSP 1.03 also uses ps. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple correction for native builds and overall code sanity.
How to reproduce:
sv_pure 0andvm_cgame 0cg_oversampleMouseto 1 and/devmapany map or connect to any serverSIGSEGV) to your quake instanceWhy
With
cg_oversampleMouse 1client prediction callsPM_UpdateViewAngles, which, in turn, uses nullishpm. This is only the first frame, soPmove, which updatespmto valid pmove, has not been called yet, sopmisNULL.It's clear that this is an oversight, all the other code of the func uses
psprovided in the args, notpm->ps.