fix(spotify): follow spicetify docs, remove incompatible installs, improve maintainability - #153
Open
yukazakiri wants to merge 2 commits into
Open
fix(spotify): follow spicetify docs, remove incompatible installs, improve maintainability#153yukazakiri wants to merge 2 commits into
yukazakiri wants to merge 2 commits into
Conversation
- check spicetify is in PATH after install - create spicetify config dir before running commands - fix chmod -R flag placement - guard spicetify -c failure and config file existence - wait for existing Spotify process to close before patching - pause after closing Spotify to release file locks - fail explicitly if backup apply still fails after prefs generation - wrap sudo chmod in error-tolerant checks so script continues if sudo fails
…ility - split monolithic script into logical phase functions - add _die() helper for consistent error handling with terminal hold - remove removed-variable tracking and unnecessary checks - add TRACE=1 debug support - consolidate theme script path into a single variable - add developer notes in header comments - use heredoc for banner text for cleaner formatting
Owner
|
Thanks @yukazakiri — the phased refactor is solid and follows the spicetify docs. Queued for an integration test on a clean Arch box first, since it removes flatpak/snap/launcher installs and I want to verify the recovery flow before merging. Will follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the Spotify setup script to follow the official Spicetify documentation, remove incompatible installations, and improve maintainability.
Problem
The existing
/setup-spotifyscript had several issues:spicetify-clivsspicetify-cli-git)Changes
Bug Fixes
com.spotify.Clientspotifyspotify-launcher(AUR)spicetify-cli-gitpackagesudo chmod a+wr /opt/spotifypermissionsbackup apply→restore backup apply→ clear stale state → retry_lib.shERR trap now callssetup_finish_pauseso the terminal stays openRefactoring
_remove_incompatible()— clean up conflicting installs_install_packages()— AUR install + PATH verification_configure_spicetify()— set paths and permissions_generate_prefs()— first-run Spotify launch_apply_spicetify()— backup apply with recovery_install_marketplace()+_apply_theme()— extras_die()helper for consistent fatal errorsTRACE=1support for bashset -xdebuggingTesting
paruAUR helperspicetify-cli-gitconflict gracefullyRelated
sudo chmodhandling