Open
Conversation
sfc-gh-jrasley
approved these changes
Dec 20, 2025
sfc-gh-mwyatt
commented
Dec 22, 2025
| hf_config_kwargs: Dict = Field(default_factory=dict) | ||
| """ Optional kwargs to override in the HF model config object created by `AutoConfig.from_pretrained(model.name_or_path)` """ | ||
|
|
||
| fp8_recipe: Optional[Any] = None |
Collaborator
Author
There was a problem hiding this comment.
Perhaps this should be named differently. TE supports both FP8 and FP4 - plus there are other libraries we may wish to support. A better name may be:
quant_recipequant_target_modules
Collaborator
Author
There was a problem hiding this comment.
@sfc-gh-jrasley @sfc-gh-zhyao thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for FP8 autocasting feature from Transformer Engine library.
nn.Linearlayers with transformer engine linear layer in loaded models for layers that substring matchfp8_target_moduleslosscalculation withautocastfp8_recipe:typethat maps to Recipe subclassfp8_target_modulesExample Usage: